Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(codegen): print bigint literal #7286

Closed
wants to merge 1 commit into from

Conversation

camc314
Copy link
Contributor

@camc314 camc314 commented Nov 14, 2024

closes #7285

Copy link

graphite-app bot commented Nov 14, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added A-codegen Area - Code Generation C-enhancement Category - New feature or request labels Nov 14, 2024
@camc314 camc314 marked this pull request as ready for review November 14, 2024 17:49
Copy link
Contributor Author

camc314 commented Nov 14, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@camc314 camc314 requested a review from Boshen November 14, 2024 17:50
Copy link

codspeed-hq bot commented Nov 14, 2024

CodSpeed Performance Report

Merging #7286 will not alter performance

Comparing c/11-14-feat_codegen_print_bigint_literal (18bded4) with main (b57d00d)

Summary

✅ 30 untouched benchmarks

@camc314 camc314 force-pushed the c/11-14-feat_codegen_print_bigint_literal branch from 4ef27d2 to 18bded4 Compare November 14, 2024 18:37
@github-actions github-actions bot added the A-isolated-declarations Isolated Declarations label Nov 14, 2024
Boshen added a commit that referenced this pull request Nov 20, 2024
@Boshen
Copy link
Member

Boshen commented Nov 20, 2024

Minification seems difficult, I'll restrict the feature to remove underscore only. #7367

@Boshen Boshen closed this Nov 20, 2024
Boshen added a commit that referenced this pull request Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-codegen Area - Code Generation A-isolated-declarations Isolated Declarations C-enhancement Category - New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

codegen: remove underscore from bigint
2 participants