Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(linter): use cow_to_ascii_lowercase instead cow_to_lowercase #8678

Conversation

Boshen
Copy link
Member

@Boshen Boshen commented Jan 23, 2025

cow_to_lowercase is slow as it deals with unicode.

closes #8659

@github-actions github-actions bot added A-linter Area - Linter A-codegen Area - Code Generation C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Jan 23, 2025
Copy link
Member Author

Boshen commented Jan 23, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

graphite-app bot commented Jan 23, 2025

Merge activity

…ase` (#8678)

`cow_to_lowercase` is slow as it deals with unicode.

closes #8659
@Boshen Boshen force-pushed the 01-23-refactor_linter_use_cow_to_ascii_lowercase_instead_cow_to_lowercase_ branch from 9c6f71f to 23b49a6 Compare January 23, 2025 13:46
@graphite-app graphite-app bot merged commit 23b49a6 into main Jan 23, 2025
25 checks passed
@graphite-app graphite-app bot deleted the 01-23-refactor_linter_use_cow_to_ascii_lowercase_instead_cow_to_lowercase_ branch January 23, 2025 13:51
Copy link

codspeed-hq bot commented Jan 23, 2025

CodSpeed Performance Report

Merging #8678 will not alter performance

Comparing 01-23-refactor_linter_use_cow_to_ascii_lowercase_instead_cow_to_lowercase_ (23b49a6) with main (883d25b)

Summary

✅ 32 untouched benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-codegen Area - Code Generation A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

a small question about cow-utils
1 participant