feat(minifier): replace Number.*_SAFE_INTEGER/Number.EPSILON
#8682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
bot
added
A-minifier
sapphi-red
force-pushed
the
01-22-feat_minifier_replace_number.positive_infinity___number.negative_infinity___number.nan_
branch
from
435b45e to
5896784
Compare
sapphi-red
force-pushed
the
01-22-feat_minifier_replace_number.__safe_integer___number.epsilon_
branch
from
af223f6 to
a506b39
Compare
Boshen
changed the base branch from
01-22-feat_minifier_replace_number.positive_infinity___number.negative_infinity___number.nan_
to
graphite-base/8682
CodSpeed Performance ReportMerging #8682 will not alter performanceComparing Summary
|
Boshen
force-pushed
the
graphite-base/8682
branch
from
5896784 to
0c5bb30
Compare
Boshen
force-pushed
the
01-22-feat_minifier_replace_number.__safe_integer___number.epsilon_
branch
from
a506b39 to
649631c
Compare
Boshen
force-pushed
the
01-22-feat_minifier_replace_number.__safe_integer___number.epsilon_
branch
from
649631c to
5d4f889
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The value of
Number.*_SAFE_INTEGER,Number.EPSILONare constants as they cannot be changed. This PR replaces them with2**53-1/-(2**53-1)/2**-52for ES2016+. For ES2015,Number.EPSILONis not changed butNumber.*_SAFE_INTEGERs are replaced with9007199254740991/-9007199254740991.Reference
Number.MAX_SAFE_INTEGERNumber.MIN_SAFE_INTEGERNumber.EPSILONAdditional Information
Number.MIN_VALUEcannot be replaced as the value depends on the runtimeNumber.MAX_VALUEcan be replaced but I didn't come up with a shorter representation that does not lack precision