fix(napi): do not support raw transfer on WASM32 #9566
Merged
+37
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
overlookmotel
force-pushed
the
03-05-fix_napi_do_not_support_raw_transfer_on_wasm32
branch
from
d3762a7 to
7c9ae6f
Compare
overlookmotel
force-pushed
the
03-05-fix_napi_do_not_support_raw_transfer_on_wasm32
branch
3 times, most recently
from
92b4ace to
10ed2d0
Compare
Brooooooklyn
approved these changes
Mar 6, 2025
Merge activity
|
Prevent compilation errors on 32-bit platforms by avoiding calculating `usize: 1 << 32` unless on a 64-bit platform. `parseSync` will throw an error if called with `experimentalRawTransfer` on an unsupported system. Add a function `rawTransferSupported` to check if raw transfer is supported on current system or not, so user can avoid these errors.
graphite-app
bot
force-pushed
the
03-05-fix_napi_do_not_support_raw_transfer_on_wasm32
branch
from
10ed2d0 to
91c9932
Compare
graphite-app bot
pushed a commit
that referenced
this pull request
Mar 6, 2025
Duplicate of #9555, but just stacked on top of #9566. `napi-rs` for some reason omits the `export * from '@oxc-project/types';` line from `index.d.ts` when building for WASM. I don't know how to fix that, so added a hacky script to fix up `index.d.ts` manually. This is not at all ideal, but at least it now compiles and CI passes.
graphite-app
bot
deleted the
03-05-fix_napi_do_not_support_raw_transfer_on_wasm32
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent compilation errors on 32-bit platforms by avoiding calculating
usize: 1 << 32unless on a 64-bit platform.parseSyncwill throw an error if called withexperimentalRawTransferon an unsupported system.Add a function
rawTransferSupportedto check if raw transfer is supported on current system or not, so user can avoid these errors.