Datagram remote_key getter #122
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added method to get remote_key from dgram_interface wrapper. In lokinet, this is the upstream RouterID; it is easier to grab it directly from the dgram_interface rather than having to create an std::shared_ptr<connection_interface> every time - It would be weird to return a ustring_view like the connection_interface method being called, as the dgram_interface makes no assurances of keeping the underlying connection objects alive - Making a copy of the ustring ensures that we are not pointing a view at data that we are not managing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remote_keyfromdgram_interfacewrapper. In lokinet, this is the upstream RouterID; it is easier to grab it directly from thedgram_interfacerather than having to create anstd::shared_ptr<connection_interface>every timeconnection_interfacemethod being called, as thedgram_interfacemakes no assurances of keeping the underlying connection objects alive