Stream Stop Read/Write #127
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jagerman
reviewed
May 7, 2024
There was a problem hiding this comment.
Left some comments in the PR.
A couple other things are needed here as well:
-
Attempting to append stream data to a stream that has writing shut down should warn and drop the data, rather than making new buffers for it and storing it.
-
A callback mechanism is needed for an application to know when the stream has entered non-read or non-write state as a result of the other side's actions. For instance, embedded lokinet's tunneled quic streams are going to need to make the appropriate
shutdowncall in response to the other side shutting down one direction of the stream.
|
@jagerman thanks for the feedback, changes made! |
- Applications can call `::set_remote_reset_hooks(...)` to emplace logic to be executed when the remote stream
shuts down reading and/or writing
- This only happens once per lifetime of the stream; as a result, do NOT set more hooks while inside the body of
the hooks themselves!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.