-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding SVG flag for Khyber Pakhtunkhwa #14
Open
RudeySH
wants to merge
19
commits into
oxguy3:master
Choose a base branch
from
RudeySH:pk-kp
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thanks @rlenders
not technically a country and this isn't an official ISO 3166-1 alpha-2 code, but this code has been reserved for the EU, so I might as well have the flag for it
This includes subdivisions from: - France (FR) - Germany (DE) - Great Britain (GB) - Mexico (MX) - Pakistan (PK) - Spain (ES) - US Minor Outlying Islands (UM)
These are both federal states of Germany. The SVG variants of these flags are already correct.
This commit does not include UK as it's already in the repository. This is discussed in oxguy3#7. For more information on exceptional reservations, see https://en.wikipedia.org/wiki/ISO_3166-1_alpha-2#Exceptional_reservations
All three are Georgian subdivisions.
Add flags for exceptionally reserved codes
Add SVG flags that were available as PNG and vice versa
Add flags for Abkhazia, Ajaria & Tbilisi
Fix squared PNG flags for SU & UN
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KP is a subdivision of Pakistan (PK). The PNG flag was already present in this repository.