React Router 7 #2628
Merged
React Router 7 #2628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
david-crespo
force-pushed
the
react-router-7
branch
from
88e44ae to
35014f0
Compare
david-crespo
force-pushed
the
react-router-7
branch
from
35014f0 to
21d33fe
Compare
david-crespo
force-pushed
the
react-router-7
branch
from
21d33fe to
a4d7af8
Compare
david-crespo
force-pushed
the
react-router-7
branch
from
f642c3b to
fa86f81
Compare
david-crespo
force-pushed
the
react-router-7
branch
from
fa86f81 to
0b67516
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is currently using a nightly release because we need remix-run/react-router#12469 for Vite 6 support, buteverything seems good. The big sticking point was thestartTransitionthing, which broke scroll restore. But when I tested it manually, it didn't actually break it, and I was able to get the test to pass consistently by adding some sleeps. If it's flaky in CI, that'll be really annoying, but otherwise I'm not too worried about this feature because I consider scroll restoration to be kind of a best-effort thing and in manual testing it feels like it's working quite well.As you can see in the diff, this doesn't require any code changes besides updating imports because we are using RR in "library mode" (fka RR v6) rather than "framework mode" (fka Remix).