Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IPv6 addresses in crutest #1503

Merged
merged 1 commit into from
Oct 11, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions crutest/src/main.rs
Original file line number Diff line number Diff line change
Expand Up @@ -843,10 +843,10 @@ async fn make_a_volume(
let mut sv_targets = Vec::new();
for _ in 0..3 {
let port = dsc_client.dsc_get_port(cid).await.unwrap();
let tar: SocketAddr =
format!("{}:{}", dsc.ip(), port.into_inner())
.parse()
.unwrap();
let tar = SocketAddr::new(
dsc.ip(),
port.into_inner().try_into().unwrap(),
);
sv_targets.push(tar);
targets.push(tar);
cid += 1;
Expand Down Expand Up @@ -880,8 +880,9 @@ async fn make_a_volume(
let mut extent_info_result = None;
for target in &crucible_opts.target {
let port = target.port() + crucible_common::REPAIR_PORT_OFFSET;
info!(test_log, "look at: http://{}:{} ", target.ip(), port);
let repair_url = format!("http://{}:{}", target.ip(), port);
let addr = SocketAddr::new(target.ip(), port);
let repair_url = format!("http://{addr}");
info!(test_log, "look at: {repair_url}");
let repair_client = repair_client::new(&repair_url);
match repair_client.get_region_info().await {
Ok(ri) => {
Expand Down