Only send flushes when Downstairs is idle; send Barrier otherwise #1505
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes automatic flushes, per RFD 518. Instead, the new
Barrier
operation is sent. If the system is idle for a particular amount of time, we send a finalFlush
to put everything into a known state.When the Upstairs retires jobs after a barrier operation, the system as a whole becomes ineligible for replay. This state determines whether the new Downstairs reconnects through
Offline
(which does replay) orFaulted
(which does live-repair instead).Removing automatic flushes is a noticeable performance improvement:
(tested on the London mini-cluster, with Upstairs and 3x Downstairs on different sleds)