Split out Downstairs-specific stats #1511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmpesp
approved these changes
Oct 17, 2024
leftwo
approved these changes
Oct 17, 2024
mkeeter
force-pushed
the
mkeeter/downstairs-stats
branch
from
7be139e
to
ce9e428
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(staged on top of #1510)
This removes another bit of awkward plumbing!
Previously, we had to pass an
&UpStatOuterto any functions in theDownstairsthat needed to update our Oximeter statistics. This PR splits theUpStatOuterinto upstairs versus downstairs components, then stores a (shared) handle to the downstairs half in theDownstairsitself.The Oximeter interface remains unchanged.
(Making the
Downstairsmore self-sufficient is a step towards doing immediate acks, i.e. eliminatingackable_jobsand simply sending acks as they become ready)