Measure network round trip time #940
Conversation
Create a network round trip dynamometer. Also, fix how the downstairs dynamometer measures IOPs.
| }, | ||
| } | ||
|
|
||
| #[tokio::main] |
There was a problem hiding this comment.
I don't love that the propocol lib is now a binary. It might be a little confusing
to someone coming in. Could we maybe rename the resulting binary protocol_test or
ptest or something to indicate that?
An additional idea, maybe a README somewhere talking about it. I've been negligent
as well in documenting what all the stuff in the crucible repo is, and we should start
getting better about leaving breadcrumbs behind to assist new readers on what the
heck all this stuff is.
There was a problem hiding this comment.
Agreed, I'd even suggest a separate binary crate so that protocol remains a pure library crate.
| #[clap(about = "Protocol serialization and deserialization speed test")] | ||
| enum Args { | ||
| Dynamometer { | ||
| #[clap(short, long, default_value_t = 512)] |
There was a problem hiding this comment.
This ones missing the doc comment.
There was a problem hiding this comment.
The doc comment should also specify the unit (it looks like bytes)
| use uuid::Uuid; | ||
|
|
||
| #[derive(Debug, Parser)] | ||
| #[clap(about = "Protocol serialization and deserialization speed test")] |
There was a problem hiding this comment.
This is really just testing writes.
Would read IO be any different, or is it just the same thing but going in the
other direction?
| @@ -8,6 +8,12 @@ pub enum DynoFlushConfig { | |||
| None, | |||
| } | |||
|
|
|||
| macro_rules! ceiling_div { | |||
There was a problem hiding this comment.
Hopefully div_ceil gets stabilized soon!
| io_operations_sent += num_writes; | ||
| io_operations_sent += ceiling_div!( | ||
| num_writes * ddef.block_size() as usize, | ||
| 16 * 1024 * 1024 |
There was a problem hiding this comment.
Can you explain where this number comes from? It's not obvious to me!
|
|
||
| io_operations_sent += num_writes; | ||
| io_operations_sent += | ||
| ceiling_div!(num_writes * write_size, 16 * 1024 * 1024); |
There was a problem hiding this comment.
Same here, not sure where 16 MiB comes from
Create a network round trip dynamometer. Also, fix how the downstairs dynamometer measures IOPs.