-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unzip was not building with bzip2 support #18
Merged
Merged
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
58b34d3
unzip was not building with bzip2 support
citrus-it 1392350
unzip: catch up on CVE fixes
citrus-it 702652d
unzip: re-base patches
citrus-it 7a6c62b
Use elfdump for testing libbz2 dependency
citrus-it d27c8ec
Review feedback
citrus-it File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
build/unzip/patches/CVE-2018-1000035-overflow-password-protect.patch
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
From: Mark Adler <[email protected]> | ||
Subject: Fix bug in undefer_input() that misplaced the input state. | ||
Origin: https://github.com/madler/unzip/commit/41beb477c5744bc396fa1162ee0c14218ec12213 | ||
Bug-Debian: https://bugs.debian.org/931433 | ||
X-Debian-version: 6.0-24 | ||
|
||
Fix bug in undefer_input() that misplaced the input state. | ||
|
||
diff -wpruN --no-dereference '--exclude=*.orig' a~/fileio.c a/fileio.c | ||
--- a~/fileio.c 1970-01-01 00:00:00 | ||
+++ a/fileio.c 1970-01-01 00:00:00 | ||
@@ -532,8 +532,10 @@ void undefer_input(__G) | ||
* This condition was checked when G.incnt_leftover was set > 0 in | ||
* defer_leftover_input(), and it is NOT allowed to touch G.csize | ||
* before calling undefer_input() when (G.incnt_leftover > 0) | ||
- * (single exception: see read_byte()'s "G.csize <= 0" handling) !! | ||
+ * (single exception: see readbyte()'s "G.csize <= 0" handling) !! | ||
*/ | ||
+ if (G.csize < 0L) | ||
+ G.csize = 0L; | ||
G.incnt = G.incnt_leftover + (int)G.csize; | ||
G.inptr = G.inptr_leftover - (int)G.csize; | ||
G.incnt_leftover = 0; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we should be using eldfump -d here as otherwise you could get a false positive if a dep of a dep had libbz2 support.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, and the test also doesn't work for cross compiled binaries such as
aarch64
. Here's an update.