gimlet: add missing temperature sensors for the ISL68224 controller #2108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We were definitely missing the 3 temperature sensors from U352, which I can add. But I don't see anything else missing for the RAA229618 or ISL68224 parts on either Gimlet or Sidecar. @ericaasen could you confirm what we are missing per #1573? edit: I'm rereading it again and I think I understand what you mean now. |
mkeeter
reviewed
Jun 24, 2025
Aaron-Hartwig
force-pushed
the
aaron/missing-sensors
branch
from
1eeac1b to
cde32f1
Compare
Aaron-Hartwig
force-pushed
the
aaron/missing-sensors
branch
from
cde32f1 to
f8b8110
Compare
|
Hmm, trying this on aaron@niles ~ $ pfexec humility -t gimlet-d -a build-gimlet-d-dev-image-default.zip sensors -t temp
humility: WARNING: archive on command-line overriding archive in environment file
humility: attached to 0483:3754:000D00344741500820383733 via ST-Link V3
NAME KIND VALUE UNPWR ERR MSSNG UNAVL TMOUT
...
VPP_ABCD temp - 0 0 0 0 0
VPP_EFGH temp - 0 0 0 0 0
V1P8_SP3 temp - 0 0 0 0 0
... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1573