Skip to content

Commit

Permalink
changes
Browse files Browse the repository at this point in the history
  • Loading branch information
sunshowers committed Feb 21, 2024
1 parent 2888060 commit 1beecc8
Show file tree
Hide file tree
Showing 10 changed files with 68 additions and 115 deletions.
121 changes: 27 additions & 94 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -607,8 +607,9 @@ opt-level = 3
#
# Local client generation during development.
#
#[patch."https://github.com/oxidecomputer/progenitor"]
#progenitor = { path = "../progenitor/progenitor" }
[patch."https://github.com/oxidecomputer/progenitor"]
progenitor = { path = "../progenitor/progenitor" }
progenitor-client = { path = "../progenitor/progenitor-client" }
#[patch."https://github.com/oxidecomputer/typify"]
#typify = { path = "../typify/typify" }

Expand Down
6 changes: 2 additions & 4 deletions dev-tools/oxlog/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -351,8 +351,7 @@ fn load_svc_logs(dir: Utf8PathBuf, logs: &mut BTreeMap<ServiceName, SvcLogs>) {

let is_current = filename.ends_with(".log");

let svc_logs =
logs.entry(svc_name.to_string()).or_insert(SvcLogs::default());
let svc_logs = logs.entry(svc_name.to_string()).or_default();

if is_current {
svc_logs.current = Some(logfile.clone());
Expand All @@ -374,8 +373,7 @@ fn load_extra_logs(
return;
};

let svc_logs =
logs.entry(svc_name.to_string()).or_insert(SvcLogs::default());
let svc_logs = logs.entry(svc_name.to_string()).or_default();

for entry in entries {
let Ok(entry) = entry else {
Expand Down
20 changes: 16 additions & 4 deletions dev-tools/xtask/src/main.rs
Original file line number Diff line number Diff line change
Expand Up @@ -26,23 +26,35 @@ enum Cmds {
/// workspace
CheckWorkspaceDeps,
/// Run configured clippy checks
Clippy,
Clippy(ClippyArgs),
}

#[derive(Parser)]
struct ClippyArgs {
/// Automatically apply lint suggestions.
#[clap(long)]
fix: bool,
}

fn main() -> Result<()> {
let args = Args::parse();
match args.cmd {
Cmds::Clippy => cmd_clippy(),
Cmds::Clippy(args) => cmd_clippy(args),
Cmds::CheckWorkspaceDeps => cmd_check_workspace_deps(),
}
}

fn cmd_clippy() -> Result<()> {
fn cmd_clippy(args: ClippyArgs) -> Result<()> {
let cargo =
std::env::var("CARGO").unwrap_or_else(|_| String::from("cargo"));
let mut command = Command::new(&cargo);
command.arg("clippy");

if args.fix {
command.arg("--fix");
}

command
.arg("clippy")
// Make sure we check everything.
.arg("--all-targets")
.arg("--")
Expand Down
2 changes: 0 additions & 2 deletions nexus/src/app/background/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,4 @@ mod region_replacement;
mod status;
mod sync_service_zone_nat;

pub use common::Driver;
pub use common::TaskHandle;
pub use init::BackgroundTasks;
Loading

0 comments on commit 1beecc8

Please sign in to comment.