Skip to content

Commit

Permalink
Fix merge conflict regarding clickhouse-admin (#6834)
Browse files Browse the repository at this point in the history
  • Loading branch information
andrewjstone authored Oct 11, 2024
1 parent d0c79b6 commit 4e8200a
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 9 deletions.
2 changes: 1 addition & 1 deletion Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

20 changes: 12 additions & 8 deletions nexus/reconfigurator/execution/src/clickhouse.rs
Original file line number Diff line number Diff line change
Expand Up @@ -92,8 +92,11 @@ pub(crate) async fn deploy_nodes(
let log = log.new(slog::o!("admin_url" => admin_url.clone()));
futs.push(Either::Left(async move {
let client = Client::new(&admin_url, log.clone());
client.generate_keeper_config(&config).await.map(|_| ()).map_err(
|e| {
client
.generate_keeper_config_and_enable(&config)
.await
.map(|_| ())
.map_err(|e| {
anyhow!(
concat!(
"failed to send config for clickhouse keeper ",
Expand All @@ -104,8 +107,7 @@ pub(crate) async fn deploy_nodes(
admin_url,
e
)
},
)
})
}));
}
for config in server_configs {
Expand All @@ -119,8 +121,11 @@ pub(crate) async fn deploy_nodes(
let log = opctx.log.new(slog::o!("admin_url" => admin_url.clone()));
futs.push(Either::Right(async move {
let client = Client::new(&admin_url, log.clone());
client.generate_server_config(&config).await.map(|_| ()).map_err(
|e| {
client
.generate_server_config_and_enable(&config)
.await
.map(|_| ())
.map_err(|e| {
anyhow!(
concat!(
"failed to send config for clickhouse server ",
Expand All @@ -131,8 +136,7 @@ pub(crate) async fn deploy_nodes(
admin_url,
e
)
},
)
})
}));
}

Expand Down

0 comments on commit 4e8200a

Please sign in to comment.