Skip to content

Commit

Permalink
clarify that both conditions hold
Browse files Browse the repository at this point in the history
  • Loading branch information
jmpesp committed Jun 18, 2024
1 parent a71824c commit 51dd50b
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions nexus/src/app/sagas/region_replacement_drive.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1368,9 +1368,11 @@ async fn srrd_drive_region_replacement_execute(
// If the Volume is active, that means reconcilation
// completed ok, and therefore Nexus can consider this
// repair complete. This is only true if one repair occurs
// at a time per volume, and if this saga locks the region
// replacement request record as part of it executing. If
// either of those conditions are not held, then multiple
// at a time per volume (which is true due to the presense
// of volume_repair records), and if this saga locks the
// region replacement request record as part of it executing
// (which it does through the SET_SAGA_ID forward action).
// If either of those conditions are not held, then multiple
// replacement calls and activation checks can interleave
// and confuse this saga.
//
Expand Down

0 comments on commit 51dd50b

Please sign in to comment.