Skip to content

Commit

Permalink
it's always been nexus-sled-agent-shared. we've always been at war wi…
Browse files Browse the repository at this point in the history
…th eastasia

Created using spr 1.3.6-beta.1
  • Loading branch information
sunshowers committed Jul 24, 2024
1 parent 420dd83 commit d30e4c8
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion nexus/types/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ omicron-passwords.workspace = true
omicron-workspace-hack.workspace = true
# Note: we're trying to avoid a dependency from nexus-types to sled-agent-types
# because the correct direction of dependency is unclear. If there are types
# common to both, put them in `omicron-common` or `omicron-common-extended`.
# common to both, put them in `omicron-common` or `nexus-sled-agent-shared`.

[dev-dependencies]
proptest.workspace = true
Expand Down
4 changes: 2 additions & 2 deletions sled-agent/src/params.rs
Original file line number Diff line number Diff line change
Expand Up @@ -257,7 +257,7 @@ pub struct Zpool {
/// Extension trait for `OmicronZoneConfig`.
///
/// This lives here because it is pretty specific to sled-agent, and also
/// requires extra dependencies that omicron-common-extended doesn't have
/// requires extra dependencies that nexus-sled-agent-shared doesn't have.
pub(crate) trait OmicronZoneConfigExt {
fn zone_name(&self) -> String;
}
Expand All @@ -274,7 +274,7 @@ impl OmicronZoneConfigExt for OmicronZoneConfig {
/// Extension trait for `OmicronZoneType` and `OmicronZoneConfig`.
///
/// This lives here because it requires extra dependencies that
/// omicron-common-extended doesn't have.
/// nexus-sled-agent-shared doesn't have.
pub(crate) trait OmicronZoneTypeExt {
fn as_omicron_zone_type(&self) -> &OmicronZoneType;

Expand Down

0 comments on commit d30e4c8

Please sign in to comment.