Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sled agent] Provision a reservoir for Propolis #2650

Closed
smklein opened this issue Mar 23, 2023 · 3 comments
Closed

[sled agent] Provision a reservoir for Propolis #2650

smklein opened this issue Mar 23, 2023 · 3 comments
Assignees
Labels
Sled Agent Related to the Per-Sled Configuration and Management
Milestone

Comments

@smklein
Copy link
Collaborator

smklein commented Mar 23, 2023

See:

This will probably be a blocker for accurate accounting in #2648

@smklein smklein added the Sled Agent Related to the Per-Sled Configuration and Management label Mar 23, 2023
@smklein smklein added this to the MVP milestone Mar 23, 2023
@jordanhendricks jordanhendricks self-assigned this May 12, 2023
@jordanhendricks
Copy link
Contributor

Note: When oxidecomputer/propolis#410 lands, and this work lands, we can update omicron/package-manifest.toml to pull in the new propolis-server build artifact. (Without the reservoir configured, the change in oxidecomputer/propolis#410 won't go well.)

@jordanhendricks
Copy link
Contributor

jordanhendricks commented May 25, 2023

#3200 gets us most of the way here: sled-agent is now capable of resizing the reservoir, but it won't use it by default. There is at least one blocker for enabling the reservoir by default:

We can test the reservoir independently by adding swap devices manually. I will add notes to #2858 about what the swap device setup will look like.

From initial testing of reservoir use in #2684, there were potentially other blockers identified but not yet understood aiui. So I will update this ticket if we identify more issues.

@jordanhendricks
Copy link
Contributor

The tickets got a little muddled here as to what is covering what, but the upshot is that with #3607 we are now provisioning the reservoir in production, which was our goal for FCS.

There is still some work to do here to manage resource limits along guest memory lines intelligently (#3228), but that is an MVP goal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Sled Agent Related to the Per-Sled Configuration and Management
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants