Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

propolis-server should use reservoir on prod gear #410

Merged
merged 1 commit into from
Jul 21, 2023

Conversation

pfmooney
Copy link
Collaborator

Add "omicron-build" feature to propolis-server which compiles out the developer-friendly vmm-reservoir check, opting to use the reservoir unconditionally on the assumption that Oxide machines will be appropriately configured for such duty.

Fix #408

Copy link
Contributor

@gjcolombo gjcolombo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. In the future, it'd be great to use the "prod" configuration in CI if we can. I filed #412 for that, but I don't think we need to block on it right now.

@jordanhendricks
Copy link
Contributor

I think we need to wait to merge this until oxidecomputer/omicron#2650 until is done, or at least wait to update the propolis dep in omicron after this is merged. I think the latter will be easier to miss than just not merging this yet.

@pfmooney
Copy link
Collaborator Author

pfmooney commented Jun 9, 2023

I think we need to wait to merge this until oxidecomputer/omicron#2650 until is done, or at least wait to update the propolis dep in omicron after this is merged. I think the latter will be easier to miss than just not merging this yet.

Yep. I was just rebasing since it had fallen behind.

@jordanhendricks jordanhendricks added this to the MVP milestone Jul 10, 2023
Add "omicron-build" feature to propolis-server which compiles out the
developer-friendly vmm-reservoir check, opting to use the reservoir
unconditionally on the assumption that Oxide machines will be
appropriately configured for such duty.

Fix oxidecomputer#408
@gjcolombo
Copy link
Contributor

When we make the change to pick this up in Omicron, we'll also need to change omicron/smf/sled-agent/non-gimlet/config.toml (and gimlet-standalone/config.toml) to specify a nonzero reservoir size, or Omicron dev clusters won't be able to start instances (unless they pick up a Propolis image that isn't built with this feature).

@pfmooney pfmooney merged commit 7729616 into oxidecomputer:master Jul 21, 2023
8 of 9 checks passed
@pfmooney pfmooney deleted the resv-query branch July 21, 2023 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

propolis-server running in a zone complains that it could not query VMM reservoir
3 participants