Add support for 'disabling' physical disks to prevent future allocations #3526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-crespo
reviewed
Jul 7, 2023
smklein
commented
Jan 8, 2024
| @@ -312,6 +326,9 @@ CREATE TABLE IF NOT EXISTS omicron.public.physical_disk ( | |||
| -- FK into the Sled table | |||
| sled_id UUID NOT NULL, | |||
|
|
|||
| -- Describes how the control plane manages this disk | |||
| state omicron.public.physical_disk_state NOT NULL, | |||
|
|
|||
There was a problem hiding this comment.
TODO(me): add an index to look up all "draining" disks".
Also maybe update the terminology here to match #4719
There was a problem hiding this comment.
Nit: I should use the term "deactivating" here, rather than "draining", because "draining" can refer to cooperative removal (e.g. in the context of draining instances from a sled)
|
During the update sync, we had an interesting discussion where we floated the following idea: Instead of storing the "State" in the disk itself, what if state was implied by presence in a blueprint? In this world:
I'm going to explore this space a bit more, since I think it would fundamentally change how the "disk state" is stored in the DB. |
This was referenced Mar 27, 2024
|
Closing in favor of #5335 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #3480
Fixes #5153