Blueprint execution: Add dataset records for Crucible zones #5143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davepacheco
approved these changes
Feb 26, 2024
| datastore: &DataStore, | ||
| all_omicron_zones: impl Iterator<Item = &OmicronZoneConfig>, | ||
| ) -> anyhow::Result<usize> { | ||
| // Before attempting to insert any datasets, first query for any existing |
There was a problem hiding this comment.
I like this behavior (and the comment).
smklein
approved these changes
Feb 27, 2024
| /// | ||
| /// Does not update existing rows. If a dataset with the given ID already | ||
| /// exists, returns `Ok(None)`. | ||
| pub async fn dataset_insert_if_not_exists( |
There was a problem hiding this comment.
This seems like it'll fit in well with the existing "sled agent inserts dataset" structure, as we transition more towards "Nexus controls dataset creation".
| filter_kind: Option<DatasetKind>, | ||
| ) -> ListResultVec<Dataset> { | ||
| opctx.authorize(authz::Action::ListChildren, &authz::FLEET).await?; | ||
| opctx.check_complex_operations_allowed()?; |
There was a problem hiding this comment.
huh TIL about this opctx call, good to know!
There was a problem hiding this comment.
It's quite new (from #4989)!
| } | ||
|
|
||
| #[cfg(test)] | ||
| mod test { |
There was a problem hiding this comment.
Thanks for all the tests in this PR!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On each invocation, for every Crucible zone present in the blueprint (all of which have already successfully been sent to sled-agent by this point), we attempt to insert a
datasetrecord for that zone, but only if a record does not already exist. The datasets themselves are created by sled-agent when we send the zone configs.Fixes #5118.