[nexus] Add a schema change to fix instance counter underflow #5838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gjcolombo
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a corollary PR to #5830 , which fixed the root cause.
Due to a bug in the virtual provisioning query, it was possible to undercount virtual provisioning information for
instances, which would result in an integer underflow for "total CPU/RAM provisioned" for a {project, silo, fleet}.
Although #5830 fixed the root cause, it's possible that in-field systems have an invalid value if they experienced this bug.
This PR uses a schema change, exploiting the fact that schema changes occur with instances offline, to reset these values to a known value.