only unset xtrace if env.sh set it first #5875
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the Buildomat logs for some of our tests didn't have execution tracing, despite
set -o xtrace
at the top of their scripts! Turns out env.sh was the cause.Despite this script being Bash-specific (
$BASH_SOURCE
) I went with a POSIXy implementation here.(Also fixed quoting, in case your checkout is within a directory path containing spaces.)