Fix "project" (silo) IP pool view perms for non-admins #5887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-crespo
commented
Jun 12, 2024
| // But what we really want to say is that any authenticated user has | ||
| // actual Read permission on any IP pool linked to their silo. | ||
| .fetch_for(authz::Action::CreateChild) | ||
| .await?; |
david-crespo
commented
Jun 12, 2024
| const PROJECT_NAME: &str = "myproj"; | ||
| create_project(client, PROJECT_NAME).await; | ||
| let silo_url = format!("/v1/system/silos/{}", cptestctx.silo_name); | ||
| let silo: Silo = object_get(client, &silo_url).await; |
There was a problem hiding this comment.
None of this is particularly interesting — I'm just setting up a silo with a non-admin user and hitting IP pool list and view.
david-crespo
commented
Jun 12, 2024
| let pool = NexusRequest::object_get(client, &url) | ||
| .authn_as(AuthnMode::SiloUser(user.id)) | ||
| .execute_and_parse_unwrap::<SiloIpPool>() | ||
| .await; |
There was a problem hiding this comment.
This fails due to 404 without the fix in the app code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5883
Authz for IP pools is undercooked. Every user has
CreateChildon them so they can allocate IPs, but they generally don't haveReadon them unless they're a fleet viewer. Ideally, we'd be able to say "you haveReadon an IP pool if it is linked to your silo", but I don't know how to express that relationship with polar (plus it requires a join to the silo-pool links table to tell).Update: after discussing this with @davepacheco in chat, we agreed on a direction but also agreed it might be fairly complicated. Based on that, I think it would be most expedient to