Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase default session timeout to 8 hours idle, 24 hours absolute #5920

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

david-crespo
Copy link
Contributor

@david-crespo david-crespo commented Jun 20, 2024

We want to make the values configurable (#5477), but in the meantime we can improve the user experience substantially by increasing the hard-coded values so people get logged out less often. I picked 8 hours/24 hours so that someone could log in in the morning and stay logged in all day.

It's worth noting that there are no deleterious effects if the IdP's own session timeout is less than ours as long as the customer is willing to accept the longer console session. It just means that whenever the user gets logged out of the console and wants to log back in, they may have to also complete the login step in their IdP.

Copy link
Contributor

@charliepark charliepark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@david-crespo david-crespo enabled auto-merge (squash) June 21, 2024 17:36
@david-crespo david-crespo merged commit 1c8de68 into main Jun 21, 2024
19 checks passed
@david-crespo david-crespo deleted the longer-session branch June 21, 2024 18:09
iliana pushed a commit that referenced this pull request Jun 21, 2024
…5920)

We want to make the values configurable (#5477), but in the meantime we
can improve the user experience substantially by increasing the
hard-coded values so people get logged out less often. I picked 8
hours/24 hours so that someone could log in in the morning and stay
logged in all day.

It's worth noting that there are no deleterious effects if the IdP's own
session timeout is less than ours as long as the customer is willing to
accept the longer console session. It just means that whenever the user
gets logged out of the console and wants to log back in, they may have
to also complete the login step in their IdP.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants