Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move transaction retry timeseries to TOML #6008

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Move transaction retry timeseries to TOML #6008

merged 1 commit into from
Jul 9, 2024

Conversation

bnaecker
Copy link
Collaborator

@bnaecker bnaecker commented Jul 5, 2024

No description provided.

@bnaecker bnaecker requested a review from smklein July 5, 2024 23:00
smklein
smklein approved these changes Jul 8, 2024
View reviewed changes
Copy link
Collaborator

@smklein smklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo getting the right units for latency!

@bnaecker bnaecker force-pushed the move-transaction-retry-timeseries-to-toml branch from 5535dc4 to 1b77125 Compare July 9, 2024 04:28
@bnaecker bnaecker requested a review from smklein July 9, 2024 04:29
@bnaecker bnaecker merged commit a043275 into main Jul 9, 2024
19 checks passed
@bnaecker bnaecker deleted the move-transaction-retry-timeseries-to-toml branch July 9, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smklein smklein smklein approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bnaecker @smklein