Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes around feature-flagging, particularly in oxql, as well as uuid-kinds, sled-storage #6036

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Fixes around feature-flagging, particularly in oxql, as well as uuid-kinds, sled-storage #6036

merged 1 commit into from
Jul 10, 2024

Conversation

zeeshanlakhani
Copy link
Collaborator

@zeeshanlakhani zeeshanlakhani commented Jul 10, 2024 •
edited
Loading

Related to #6018, but without the CI/xtask bits.

david-crespo
david-crespo approved these changes Jul 10, 2024
View reviewed changes
Copy link
Contributor

@david-crespo david-crespo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes my problem. See #6018 (comment)

bnaecker
bnaecker approved these changes Jul 10, 2024
View reviewed changes
Copy link
Collaborator

@bnaecker bnaecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! One question, not a blocker. Thanks for splitting this out, makes a lot of sense while you continue to figure out the best path on CI feature-checking.

oximeter/db/src/lib.rs Outdated Show resolved Hide resolved
@zeeshanlakhani zeeshanlakhani mentioned this pull request Jul 10, 2024
Merged
3 tasks
@zeeshanlakhani zeeshanlakhani enabled auto-merge (squash) July 10, 2024 18:48
@zeeshanlakhani zeeshanlakhani merged commit 808b1a1 into main Jul 10, 2024
20 checks passed
@zeeshanlakhani zeeshanlakhani deleted the zl/feature-fixes branch July 10, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnaecker bnaecker bnaecker approved these changes

@david-crespo david-crespo david-crespo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zeeshanlakhani @bnaecker @david-crespo