[sled-agent] remove NexusClientWithResolver #6283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.6-beta.1
Created using spr 1.3.6-beta.1
andrewjstone
approved these changes
Aug 12, 2024
sunshowers
deleted the
sunshowers/spr/sled-agent-remove-nexusclientwithresolver
branch
sunshowers
added a commit
that referenced
this pull request
Aug 13, 2024
Building on the changes in #6138, this PR turns the sled-agent API into a trait. This is high-impact because it currently is part of a circular dependency with the Nexus internal API -- this PR gets us to the point where the OpenAPI documents can be generated independently of each other. There is some code movement but there are no functional changes in this PR -- I didn't use `replace` here to keep the PR small. I'll try out `replace` for some of the types with `From` impls in a subsequent PR. (I did change the internal `VpcFirewallRule` to `ResolvedVpcFirewallRule` to match the other types in the destination file.) I've also added some documentation about when `nexus-sled-agent-shared` should be used. Depends on #6283.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we would carry around a DNS resolver -- however, the resolver has
been unused for a while. And in fact there's a warning about being careful
around using it.
Because the type was public, the rustc dead code detector didn't figure that
out until my change to switch to an API trait in #6159 exposed this.
Remove
NexusClientWithResolver, adding a couple of free functions to make aNexusClientinstead.