Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

include backtrace from omdb panic from within omdb tests #6516

Merged
merged 2 commits into from
Sep 19, 2024
Merged

include backtrace from omdb panic from within omdb tests #6516

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5c593bf
include backtrace from omdb panic from within omdb tests
davepacheco Sep 4, 2024
f013c17
do not print stacktraces for all the Errors that we cleanly handle
davepacheco Sep 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions dev-tools/omdb/tests/test_all_output.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -502,11 +502,15 @@ async fn do_run_extra<F>(
tokio::task::spawn_blocking(move || {
let exec = modexec(
Exec::cmd(cmd_path)
// Set RUST_BACKTRACE for consistency between CI and
// developers' local runs. We set it to 0 only to match
// what someone would see who wasn't debugging it, but we
// could as well use 1 or "full" to store that instead.
.env("RUST_BACKTRACE", "0")
// Set RUST_BACKTRACE explicitly for consistency between CI
// and developers' local runs. We set it to 1 so that in
// the event of a panic, particularly in CI, we have more
// information about what went wrong. But we set
// RUST_LIB_BACKTRACE=1 so that we don't get a dump to
// stderr for all the Errors that get created and handled
// gracefully.
.env("RUST_BACKTRACE", "1")
.env("RUST_LIB_BACKTRACE", "0")
.args(&owned_args),
);
run_command(exec)
Expand Down
Loading