Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[oximeter] Use qorb within the Oximeter collector #6745

Merged
merged 5 commits into from
Oct 16, 2024
Merged

Conversation

smklein
Copy link
Collaborator

@smklein smklein commented Oct 1, 2024

Uses qorb to dynamically discover the location of Clickhouse and Nexus within the Oximeter Collector.

Fixes #6407

@smklein smklein marked this pull request as ready for review October 2, 2024 16:12
@smklein smklein requested a review from bnaecker October 2, 2024 16:13
Copy link
Collaborator

@bnaecker bnaecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! One nit and a question on the TTLs, but otherwise LGTM.

oximeter/collector/src/lib.rs Outdated Show resolved Hide resolved
oximeter/collector/src/lib.rs Show resolved Hide resolved
oximeter/collector/src/lib.rs Show resolved Hide resolved
oximeter/collector/src/agent.rs Show resolved Hide resolved
oximeter/collector/src/agent.rs Show resolved Hide resolved
oximeter/collector/src/lib.rs Show resolved Hide resolved
oximeter/collector/src/lib.rs Show resolved Hide resolved
oximeter/collector/src/lib.rs Show resolved Hide resolved
oximeter/db/src/client/mod.rs Show resolved Hide resolved
oximeter/db/src/client/mod.rs Show resolved Hide resolved
@davepacheco davepacheco added this to the 12 milestone Oct 4, 2024
@smklein
Copy link
Collaborator Author

smklein commented Oct 4, 2024

Ready to merge, just waiting for a release 11 branch to get cut!

@smklein smklein enabled auto-merge (squash) October 15, 2024 17:41
@smklein smklein merged commit e0b3052 into main Oct 16, 2024
16 of 17 checks passed
@smklein smklein deleted the oximeter-qorb branch October 16, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Oximeter collector needs a way to lookup ClickHouse more often
3 participants