Update SMF properties for Dendrite to include sled identifiers #6793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeeshanlakhani
force-pushed
the
zl/smf-sled-idents
branch
3 times, most recently
from
8a554ca
to
74703e1
Compare
zeeshanlakhani
commented
Oct 9, 2024
package-manifest.toml
Outdated
| source.commit = "f3810e7bc1f0d746b5e95b3aaff32e52b02dfdfa" | ||
| source.sha256 = "c1506f6f818327523e6ff3102432a2038d319338b883235664b34f9132ff676a" | ||
| source.commit = "f79076d4630895a0177839ea041c355e2589b9c1" | ||
| source.sha256 = "7dbd752327234d6321ae9b06fb1eb72874bd3bcf0122ee545f60fe2579d9746c" |
There was a problem hiding this comment.
TODO: settle these hashes when https://github.com/oxidecomputer/dendrite/pull/1031 is settled.
zeeshanlakhani
force-pushed
the
zl/smf-sled-idents
branch
2 times, most recently
from
95605dc
to
30441ac
Compare
zeeshanlakhani
force-pushed
the
zl/smf-sled-idents
branch
12 times, most recently
from
dbdd3c7
to
ca76be2
Compare
zeeshanlakhani
commented
Oct 16, 2024
| versions = [ | ||
| { version = 1, fields = [ "rack_id", "sled_id", "sled_model", "sled_revision", "sled_serial", "switch_id", "switch_model", "switch_revision", "switch_serial" ] }, | ||
| { version = 1, fields = [ "rack_id", "sled_id", "sled_model", "sled_revision", "sled_serial", "switch_id", "switch_fab", "switch_lot", "switch_wafer", "switch_wafer_loc_x", "switch_wafer_loc_y", "switch_model", "switch_revision", "switch_serial", "switch_slot" ] }, |
There was a problem hiding this comment.
Separated out x,y fields here for wafer location (vs storing a tuple).
bnaecker
reviewed
Oct 21, 2024
Includes: - package-manifest update to match the properties added to dpd - removal of client call to get sled idenifier information (no longer used) - switch_slot added to oximeter schemas for dendrite/switch-data-link
zeeshanlakhani
force-pushed
the
zl/smf-sled-idents
branch
from
83f2de6
to
bfffdf5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update SMF properties for Dendrite to include sled identifiers
Includes:
Related: