-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update SMF properties for Dendrite to include sled identifiers #6793
base: main
Are you sure you want to change the base?
Conversation
8a554ca
to
74703e1
Compare
package-manifest.toml
Outdated
source.commit = "f3810e7bc1f0d746b5e95b3aaff32e52b02dfdfa" | ||
source.sha256 = "c1506f6f818327523e6ff3102432a2038d319338b883235664b34f9132ff676a" | ||
source.commit = "f79076d4630895a0177839ea041c355e2589b9c1" | ||
source.sha256 = "7dbd752327234d6321ae9b06fb1eb72874bd3bcf0122ee545f60fe2579d9746c" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: settle these hashes when https://github.com/oxidecomputer/dendrite/pull/1031 is settled.
95605dc
to
30441ac
Compare
dbdd3c7
to
ca76be2
Compare
versions = [ | ||
{ version = 1, fields = [ "rack_id", "sled_id", "sled_model", "sled_revision", "sled_serial", "switch_id", "switch_model", "switch_revision", "switch_serial" ] }, | ||
{ version = 1, fields = [ "rack_id", "sled_id", "sled_model", "sled_revision", "sled_serial", "switch_id", "switch_fab", "switch_lot", "switch_wafer", "switch_wafer_loc_x", "switch_wafer_loc_y", "switch_model", "switch_revision", "switch_serial", "switch_slot" ] }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Separated out x,y fields here for wafer location (vs storing a tuple).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty straightforward, thanks! I've a couple of questions, the most important is around making sure that this sequence of commits won't break development or CI workflows. Thanks for taking this on!
Includes: - package-manifest update to match the properties added to dpd - removal of client call to get sled idenifier information (no longer used) - switch_slot added to oximeter schemas for dendrite/switch-data-link
83f2de6
to
bfffdf5
Compare
f02e003
to
ab1f377
Compare
Update SMF properties for Dendrite to include sled identifiers
Includes:
Related: