Discretionary single-node ClickHouse zones #6800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plotnick
force-pushed
the
discretionary-clickhouse
branch
from
911a7dc
to
8d36d38
Compare
andrewjstone
approved these changes
Oct 8, 2024
Reverts commit `0b4dcd3d4f899932e14599217012f8553798b9a1` in favor of this approach. The alternative would be to add similar policy assignments to the other failing tests.
jgallagher
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automatically allocate one single-node ClickHouse zone.
This is almost completely independent of the ongoing multi-node ClickHouse Server/Keeper work, except that we try to respect the new
ClickhousePolicy::deploy_with_standaloneflag if present.Validated on
a4x2by manually expunging the sole ClickHouse zone in the current blueprint and then regenerating.