Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add policy to the db #6823

Closed
wants to merge 5 commits into from
Closed

Add policy to the db #6823

wants to merge 5 commits into from

Conversation

andrewjstone
Copy link
Contributor

Still need to add queries and usage.

@andrewjstone
Add support for clickhouse keeper inventory collection
6323462 
I made small change to the types stored in inventory to not collect
OmicronZoneUuids for each keeper. This allows collection based on DNS
names alone. The zone ids were never actually used for anything anyway.

Note that this won't collect anything right now because we won't
have any DNS names for clickhouse-admin-keepers.
@andrewjstone
whoopsie, forgot to declare the primary key
b4b0c74
@andrewjstone
representative inventory and deletion
c557922
@andrewjstone
review fixes
0af62e3
@david-crespo
Copy link
Contributor

We have a lot of policies — what do you think about adding a qualifier to the name of the table and the model to indicate what it is a policy for?

@andrewjstone
Copy link
Contributor Author

We have a lot of policies — what do you think about adding a qualifier to the name of the table and the model to indicate what it is a policy for?

:) That's part of the problem I'm having. You can read my soliloquy in the #oxide-update channel, but the short form is that
I don't believe there is a good qualifier for it. Right now it's the "rack policy", but in the future it will be the "AZ" or "Region" or "Cell" policy. I suppose I can just call it rack_policy for now, as that's the most correct, and I completely agree with you that policy is too generic.

@david-crespo
Copy link
Contributor

david-crespo commented Oct 10, 2024 •
edited
Loading

Rack policy for deciding what?

@andrewjstone
Copy link
Contributor Author

Rack policy for deciding what?

I changed it to reconfigurator_policy as discussed in chat. Thanks for the feedback @david-crespo.

Base automatically changed from clickhouse-inventory-collection to main October 11, 2024 14:31
@andrewjstone
Copy link
Contributor Author

Closing in favor of #6862

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewjstone @david-crespo