Better support for parsing date-related data types from ClickHouse #6863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Support parsing timezones out of `DateTime` and `DateTime64` types, and add support for `Date` type. - Switch to using `nom` for more robust parsing of these types. - Fix bug in block concatenation, where we concatenated rows but didn't update the contained row count. Add regression test. - Add a new USDT probe for data packets specifically, with size and column names / types
bnaecker
commented
Oct 14, 2024
oximeter/db/src/native/io/column.rs
Outdated
| dst.reserve(values.len() * std::mem::size_of::<u16>()); | ||
| for value in values { | ||
| let days = value.signed_duration_since(EPOCH).num_days(); | ||
| dst.put_u16_le(u16::try_from(days).unwrap()); |
There was a problem hiding this comment.
We shouldn't unwrap here. We can do that when deserializing values from ClickHouse, because the range must have already been validated to fit in a u16 for ClickHouse to have stored it in the first place. These values are from us, and start as chrono::NaiveDates, which have a wider range than ClickHouse supports. We need to check that and fail this call if they're out of range.
There was a problem hiding this comment.
Made this and the related pieces fallible in ff0af17
|
Sorry to request a review and then push more commits. This is indeed ready for a review! |
andrewjstone
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DateTimeandDateTime64types, and add support forDatetype.nomfor more robust parsing of these types.