[test-util] Embiggen SP-sim discovery timeout #6879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Presently, the `gateway_test_utils::setup::test_setup_with_config` function will give MGS up to one second to discover the simulated SPs while setting up to perform a MGS test. This is probably not long enough, as we've seen tests fail spuriously here (c.f. #6877). This commit changes the one-second timeout to a 30-second timeout. Thirty seconds seems overly generous here, but it's probably good to be overly generous, since in most cases, it will finish in substantially less than that, and being generous reduces the risk of spurious test failures. We would hope this fixes the flakiness issue I cited above. Unfortunately, the [problem of induction][1] exists, making it technically impossible to definitively prove that a test, once shown to be flaky, is unflaky. So, if we choose to adhere strictly to [falsifiability][2], a prevailing notion in the philosophy of science, no "flaky test" issue should never be closed once it has been opened. :) [1]: https://en.wikipedia.org/wiki/Problem_of_induction [2]: https://en.wikipedia.org/wiki/Falsifiability#Basic_statements_and_the_definition_of_falsifiability
jgallagher
approved these changes
Oct 15, 2024
|
Looks like this test flake fix failed to merge because it hit test flake #6771 🫠 https://github.com/oxidecomputer/omicron/pull/6879/checks?check_run_id=31580743316 Rerunning it... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Presently, the
gateway_test_utils::setup::test_setup_with_configfunction will give MGS up to one second to discover the simulated SPs while setting up to perform a MGS test. This is probably not long enough, as we've seen tests fail spuriously here (c.f. #6877).This commit changes the one-second timeout to a 30-second timeout. Thirty seconds seems overly generous here, but it's probably good to be overly generous, since in most cases, it will finish in substantially less than that, and being generous reduces the risk of spurious test failures.
We would hope this fixes the flakiness issue I cited above. Unfortunately, the problem of induction exists, making it technically impossible to definitively prove that a test, once shown to be flaky, is unflaky. So, if we choose to adhere strictly to falsifiability, a prevailing notion in the philosophy of science, no "flaky test" issue should never be closed once it has been opened. :)