Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update InsertVpcSubnetQuery IP Block conflict detection logic #6880

Merged
merged 7 commits into from
Oct 18, 2024
Merged

Update InsertVpcSubnetQuery IP Block conflict detection logic #6880

merged 7 commits into from
Oct 18, 2024

Commits on Oct 18, 2024

  1. Expand vpc_subnet tests 

    Explicitly cover cases where VPC Subnets are being added with the same
network address but differing CIDR masks, e.g. 172.30.0.0/22 and
172.30.0.0/23.

Signed-off-by: Trey Aspelund <[email protected]>
    @taspelund
    taspelund committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    8892456 View commit details
    Browse the repository at this point in the history

  2. Update conflict logic for InsertVpcSubnetQuery 

    Signed-off-by: Trey Aspelund <[email protected]>
    @taspelund
    taspelund committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    e2fdf46 View commit details
    Browse the repository at this point in the history

  3. Update CAST logic to test ipv4 in both directions 

    Currently the error machinery emits v4 / v6 based on running an
additional check to see _which_ address field overlapped. We
need to update this check to work in both directions.
    @internet-diglett @taspelund
    internet-diglett authored and taspelund committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    9339000 View commit details
    Browse the repository at this point in the history

  4. update comment for ipv4/ipv6 overlap CAST logic

    @taspelund
    taspelund committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    5fff0d1 View commit details
    Browse the repository at this point in the history

  5. replace bi-directional comparisons with bitwise comparison

    @internet-diglett @taspelund
    internet-diglett authored and taspelund committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    ced2bb4 View commit details
    Browse the repository at this point in the history

  6. update comment for bitwise ipv4/ipv6 overlap CAST logic

    @taspelund
    taspelund committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    22ad7b3 View commit details
    Browse the repository at this point in the history

  7. Split long strings in vpc_subnet tests 

    Signed-off-by: Trey Aspelund <[email protected]>
    @taspelund
    taspelund committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    c360e2b View commit details
    Browse the repository at this point in the history