-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: use correct primary NIC for External IP add/delete/refresh #6890
Open
FelixMcFelix
wants to merge
1
commit into
main
Choose a base branch
from
felixmcfelix/eip-on-only-primary-nic
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`InstanceRunner` has been using the wrong primary NIC for Ephemeral/Floating IP addition/removal for some time, assuming that the Slot 0 NIC is always the primary. Now that External IP state is regularly re-asserted to keep Internet Gateway tags up-to-date, this led to OPTE ports reporting the use of external IPs on both the primary and slot0 nic, when multiple NICs are present. This PR makes the correct NIC selection for all three operations.
Testing NotesAn instance was set up with two NICs (with addrs
Adding a new floating IP to this instance places it on opte8 as expected (and leaves opte7 untouched):
As does removing the ephemeral IP:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
InstanceRunner
has been using the wrong primary NIC for Ephemeral/Floating IP addition/removal for some time, assuming that the Slot 0 NIC is always the primary. Now that External IP state is regularly re-asserted to keep Internet Gateway tags up-to-date, this led to OPTE ports reporting the use of external IPs on both the primary and slot0 nic, when multiple NICs are present and external IP state is changed on the instance.This PR makes the correct NIC selection for all three operations.