Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make qemu debug port output configurable #552

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pfmooney
Copy link
Collaborator

The default of dumping debug.out files everywhere that propolis-standalone is run is a bit unnecessary if that output isn't desired.

@gjcolombo
Copy link
Contributor

I think we might've discussed this offline, but I forget where we landed on the idea: what about using the Propolis logger as a sink for these messages (possibly sticking an extra key/value pair on them for easy filtering)? That would not only avoid having debug.out files, it would mean we'd have just one set of logging options to rule them all (if you don't want any logging then you can just route the entire log to /dev/null, or logging will just happen on the console if that's the default, or what-have-you).

@pfmooney
Copy link
Collaborator Author

Doing that would imply adding line-buffering to the debug port output, lest it turn every byte of log output into a line of slog output. Even with that, I'm not sure how we would appreciate having to filter those out when looking at the propolis logs. I've been working on various bits to cut down on the background noise which we emit in those logs (unhandled MSRs/registers/etc)

Copy link
Contributor

@gjcolombo gjcolombo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did line buffering for PHD long enough ago that I forgot it's a freestanding problem we'd have to solve 😅

This LGTM, let's go ahead and merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants