Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop pinning clang in windows ucrt #47

Closed
wants to merge 9 commits into from
Closed

Stop pinning clang in windows ucrt #47

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
5e6072b
Stop pinning clang in windows ucrt
jbourassa Jan 2, 2025
09a5381
Debug: list clang includes
jbourassa Jan 9, 2025
51a8d3e
Try with clang 15 but with clang 18 includes, why not?
jbourassa Jan 9, 2025
d1bb492
What if we only incldue 1 header?
jbourassa Jan 9, 2025
a7ac54e
Hmm, what's in that dir?
jbourassa Jan 10, 2025
1d5fd5f
what if we download stdckdint?
jbourassa Jan 10, 2025
0ed35c4
Does that even make its way to clang?
jbourassa Jan 10, 2025
d179b40
...
jbourassa Jan 10, 2025
33f0cd8
Use existing header
jbourassa Jan 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions setup-ruby-and-rust/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -349,19 +349,27 @@ runs:
exit 1
fi

libclang_path="$msys_root/opt/llvm-15/bin"
bindgen_extra_clang_args="--target=${{ steps.derive-toolchain.outputs.toolchain }} --sysroot=$msys_root"
libclang_path=$msys_root/opt/llvm-15/bin

extra_includes=$msys_root/opt/rb-sys/include
mkdir -p $msys_root/opt/rb-sys/include
cp 'C:\Program Files\LLVM\lib\clang\18\include\stdckdint.h' $extra_includes

bindgen_extra_clang_args="--target=${{ steps.derive-toolchain.outputs.toolchain }} --sysroot=$msys_root -I$extra_includes"

echo "::info::List clang include dir"
echo "int main() { return 0; }" > foo.c && clang foo.c -v

echo "::info::Listing files in $libclang_path"
ls -la "$libclang_path"
echo "::info::Listing files in $msys_root"
ls -la "$msys_root"

# We can't use llvm-16 just yet due to backwards compatibility issues, so we have to workaround for now
echo MSYS_ROOT="$msys_root" >> $GITHUB_ENV
echo LIBCLANG_PATH="$libclang_path" >> $GITHUB_ENV
echo "$libclang_path" >> $GITHUB_PATH
echo BINDGEN_EXTRA_CLANG_ARGS="$bindgen_extra_clang_args" >> $GITHUB_ENV


echo "::info::Set LIBCLANG_PATH to $libclang_path"
echo "::info::Set BINDGEN_EXTRA_CLANG_ARGS to $bindgen_extra_clang_args"