Implemented StableApiDefinition::thread_sleep for TruffleRuby. #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goyox86
changed the title
|
@goyox86 can we use |
goyox86
force-pushed
the
goyox86/stable-api-thread-sleep
branch
2 times, most recently
from
1451bb0 to
68136ea
Compare
goyox86
changed the title
goyox86
force-pushed
the
goyox86/stable-api-thread-sleep
branch
from
68136ea to
35f90e0
Compare
Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #450
Very naive implementation, I think we probably should be using something that allows us to go sub-second. someting that takes a pointer to `rb_cTime or directly a timeval.