Add support for Docker aliases #493
Conversation
stanhu
force-pushed
the
sh-alias-gnu-builds
branch
from
86a6068 to
7b8dfb3
Compare
| - ruby_target: x64-mingw32 | ||
| - ruby_target: x64-mingw-ucrt | ||
| # - ruby_target: x86-linux | ||
| toolchain: ${{ fromJSON(needs.fetch_ci_data.outputs.toolchains-data) }} |
There was a problem hiding this comment.
This will include x86-linux again; do we want to omit it?
There was a problem hiding this comment.
if it builds, i'm ok with it! there was an issue before breaking builds :/
stanhu
force-pushed
the
sh-alias-gnu-builds
branch
4 times, most recently
from
68ba67e to
1fd942d
Compare
|
I think this is working, though https://github.com/oxidize-rb/rb-sys/actions/runs/12818599166/job/35744460713?pr=494 is failing because the tag has a leading |
stanhu
force-pushed
the
sh-alias-gnu-builds
branch
2 times, most recently
from
51be4be to
ddbeb51
Compare
stanhu
force-pushed
the
sh-alias-gnu-builds
branch
from
ddbeb51 to
8b61115
Compare
|
In https://github.com/oxidize-rb/rb-sys/actions/runs/12819077576/job/35745982383?pr=494, you can see the In https://github.com/oxidize-rb/rb-sys/actions/runs/12819077576/job/35745984135?pr=494, you can see the |
|
@ianks Friendly ping. Could you review this? |
stanhu
force-pushed
the
sh-alias-gnu-builds
branch
from
8b61115 to
60e96c2
Compare
stanhu
force-pushed
the
sh-alias-gnu-builds
branch
from
60e96c2 to
dcebf6e
Compare
rake-compiler-dock now makes a clear distinction between GNU and Musl builds: https://github.com/rake-compiler/rake-compiler-dock?tab=readme-ov-file#linux-gnu-and-musl-important-details This change makes it possible to build images using the explicit aarch64-linux-gnu and x86_64-linux-gnu targets needed by rake-compiler-dock.
stanhu
force-pushed
the
sh-alias-gnu-builds
branch
from
dcebf6e to
b7b7d6c
Compare
|
@ianks I think this pull request is needed to unblock a few Rust extensions that use the latest version of |
|
Thank you! I will but a release after docker builds pass |
|
I think we have a bit of a chicken and egg issue here. https://github.com/oxidize-rb/rb-sys/actions/runs/13020345559/job/36319402338 is failing because UPDATE: No, something else is not right... |
|
https://github.com/oxidize-rb/rb-sys/actions/runs/13020479341/job/36319817845 is the most recent one, not sure what's wrong :/ |
|
I think the issue is that I think we can fix this by making |
|
I submitted #499. |
|
great minds think alike :) |
|
In https://github.com/oxidize-rb/rb-sys/actions/runs/13020479341/job/36319819895, I see this failure: The main difference between that build and the working one in https://github.com/oxidize-rb/rb-sys/actions/runs/12814269578/job/35730294848 is the inclusion of I've seen the error above when the Ruby versions weren't right for the image. |
|
We may need to lock versions to rake-compiler dock now that i think of it |
|
It looks like |
|
I've reproduced the current issue. I think the issue is the full Ruby patch release version has to be used, but they're not be specified right now for some reason. |
`matrix.platform.ruby_target` should now be `env.ruby_platform`. These were missed in oxidize-rb#493.
`matrix.platform.ruby_target` should now be `env.ruby_platform`. These were missed in #493.
oxidize-rb#364 upgraded the x86-mingw32 LLVM version to v17.0.6 (https://github.com/mstorsjo/llvm-mingw/releases/tag/20231128) but the version and include directories were not incremented. Previously the x86-mingw32 builds never ran, so this issue was not found until oxidize-rb#493.
rake-compiler-dock now makes a clear distinction between GNU and Musl builds:
https://github.com/rake-compiler/rake-compiler-dock?tab=readme-ov-file#linux-gnu-and-musl-important-details
This change makes it possible to build images using the explicit aarch64-linux-gnu and x86_64-linux-gnu targets needed by rake-compiler-dock.