-
-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Surfacing warnings during successful runs #4556
Merged
Merged
+569
−61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦙 MegaLinter status:
|
Descriptor | Linter | Files | Fixed | Errors | Warnings | Elapsed time |
---|---|---|---|---|---|---|
✅ API | spectral | 1 | 0 | 0 | 1.7s | |
bash-exec | 6 | 1 | 0 | 0.05s | ||
✅ BASH | shellcheck | 6 | 0 | 0 | 0.25s | |
✅ BASH | shfmt | 6 | 0 | 0 | 0 | 0.89s |
✅ COPYPASTE | jscpd | yes | no | no | 2.88s | |
✅ DOCKERFILE | hadolint | 129 | 0 | 0 | 33.68s | |
✅ JSON | jsonlint | 20 | 0 | 0 | 0.2s | |
✅ JSON | v8r | 22 | 0 | 0 | 14.31s | |
markdownlint | 267 | 0 | 302 | 0 | 23.17s | |
✅ MARKDOWN | markdown-table-formatter | 267 | 0 | 0 | 0 | 169.26s |
bandit | 215 | 66 | 0 | 3.12s | ||
✅ PYTHON | black | 215 | 0 | 0 | 0 | 5.51s |
✅ PYTHON | flake8 | 215 | 0 | 0 | 2.06s | |
✅ PYTHON | isort | 215 | 0 | 0 | 0 | 1.32s |
✅ PYTHON | mypy | 215 | 0 | 0 | 11.59s | |
✅ PYTHON | pylint | 215 | 0 | 0 | 34.8s | |
✅ PYTHON | ruff | 215 | 0 | 0 | 0 | 0.64s |
✅ REPOSITORY | checkov | yes | no | no | 39.07s | |
✅ REPOSITORY | git_diff | yes | no | no | 0.79s | |
grype | yes | 31 | no | 14.6s | ||
✅ REPOSITORY | secretlint | yes | no | no | 12.31s | |
✅ REPOSITORY | trivy | yes | no | no | 15.74s | |
✅ REPOSITORY | trivy-sbom | yes | no | no | 0.75s | |
trufflehog | yes | 1 | no | 55.51s | ||
✅ SPELL | cspell | 718 | 0 | 0 | 12.55s | |
lychee | 349 | 28 | 0 | 6.6s | ||
✅ XML | xmllint | 3 | 0 | 0 | 0 | 0.9s |
✅ YAML | prettier | 160 | 0 | 0 | 0 | 4.62s |
✅ YAML | v8r | 102 | 0 | 0 | 31.03s | |
✅ YAML | yamllint | 161 | 0 | 0 | 3.45s |
See detailed report in MegaLinter reports
echoix
approved these changes
Feb 17, 2025
I didn't go into too much detail , but I assume that this handles the cases when errors as warnings is used (because I saw that you use the yellow triangle, but it was already used) |
Looks like a quality PR :) Maybe also handle the retrieve of warnings when output is SARIF ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed code so that the console shows a new tab called "warnings" which shows a list of warnings. Added the regex to .yaml files for both errors and warnings as a way to display the warnings
Even when there are no errors, warnings will now show in the console and be displayed
Developers can also add their own regex to each descriptor to count warnings
TODO: Add the warnings to additional reporters
Fixes #4476
Proposed Changes
Readiness Checklist
Run megalinter and there should now be a warning tab. Only .yaml files at the current moment support the counting of warnings. Other files will need additional regex to be written.
Author/Contributor
Reviewing Maintainer
breaking
if this is a large fundamental changeautomation
,bug
,documentation
,enhancement
,infrastructure
, orperformance