Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add QR code flag to goshy #58

Merged
merged 1 commit into from
Sep 15, 2024
Merged

Add QR code flag to goshy #58

merged 1 commit into from
Sep 15, 2024

Conversation

riotbib
Copy link
Contributor

@riotbib riotbib commented Mar 27, 2024

This commit adds an additional flag for displaying an QR code as the respone of running goshy. It requires the qrencode package.

One could check if the depedency exists, but any OS should be able to report this themselves. So this bloat was not added.

Sadly qrencode -t ASCII was not working for me. It printed a not scannable QR code. Thus an image is opened.

This commit adds an additional flag for displaying an QR code as the
respone of running goshy. It requires the qrencode package.

One could check if the depedency exists, but any OS should be able to
report this themselves. So this bloat was not added.
@oxzi
Copy link
Owner

oxzi commented Sep 15, 2024

Thanks for your contribution and please excuse the delay.

On which system did you test this change? On my Linux-based OS with xdg-open version 1.2.1, it does not seem to be possible to read from stdin via -. Btw, using /dev/stdin failed for me as well.

$ ./contrib/bash/goshy -q __FILE__
xdg-open: unexpected option '-'
Try 'xdg-open --help' for more information.

Sadly qrencode -t ASCII was not working for me. It printed a not scannable QR code. Thus an image is opened.

qrencode -t UTF8 worked for me.

Furthermore, I have changed the logic to allow both passing -u and -q.

@oxzi oxzi merged commit b4997cb into oxzi:main Sep 15, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants