fix branch selection #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements viewport-based scrolling for the create worktree dialog to
support browsing through large branch lists in small terminals.
Features:
- Viewport rendering with automatic scroll adjustment during navigation
- Visual scroll indicators ("▲ more above" / "▼ more below")
- Terminal resize detection with scroll position recalculation
- Minimum height validation (15 lines) with error messaging
- Selection always visible with 2-line margin for smooth scrolling
Technical changes:
- Added LineType enum to represent flattened line structure
- Added scroll state tracking (scroll_offset, last_known_height,
last_known_content_height)
- Implemented ensure_selected_visible() with proper indicator space
accounting
- Added comprehensive unit tests for scroll logic (8 new tests)
- Dialog auto-closes if terminal resized below minimum height
All 24 interactive tests pass. Supports repositories with 100+ branches
in terminals as small as 15 lines.
Make terminal size query graceful for test environments where TestBackend doesn't support querying terminal size. Falls back to a reasonable default height of 24 lines when size() returns an error. This fixes CI test failures while maintaining runtime behavior.
The CI tests were failing because handle_enter() was using crossterm::terminal::size() which throws errors in test environments where TestBackend doesn't support terminal size queries. Changed to use self.terminal.size().unwrap_or(24) to match the graceful fallback pattern used in handle_create_key(), providing a reasonable default height when the terminal size cannot be queried.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #16 +/- ##
==========================================
+ Coverage 80.38% 80.92% +0.53%
==========================================
Files 15 15
Lines 4991 5210 +219
==========================================
+ Hits 4012 4216 +204
- Misses 979 994 +15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ozankasikci
force-pushed
the
001-if-the-the
branch
from
1dac5cf to
08cd6b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.