Add by-default CSRF-protection to writeJSON #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually the commit also includes a writeJSONP function which writes JSONP (content type application/javascript instead of json, and a callback wrapping the json). |
- Renamed writeJSON to writeJSONUnprotected for unprotected JSON. - writeJSON now prefixes the JSON with ")]}',\n" which is stripped away by AngularJS by default. Documented how to achieve the same with a jQuery front-end. - Added new function writeJSONWrapped with configurable wrapping. - Added new function writeJSONP for JSONP output.
|
i'd like to see this in snap-extras as well. any objections? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added two extra functions, writeJSONWrapped, and writeJSONUnprotected.
The original writeJSON is renamed to writeJSONUnprotected
writeJSON prefixes with ")]}',\n" which is stripped away by AngularJS
by default.
writeJSONWrapped can wrap with a specific wrapper