Medal Distribution tool #521
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenjaminSchaaf
requested changes
Apr 15, 2024
| @league = League.includes(:tiebreakers).find(params[:id]) | ||
| end | ||
|
|
||
| before_action only: [:medals] do | ||
| @league = League.includes(:tiebreakers).find(params[:league_id]) |
There was a problem hiding this comment.
With the route change this shouldn't be needed. :medals shouldn't be excepted from the previous before_action.
There was a problem hiding this comment.
Unable to find league ID when I removed the exception and those two lines, re-adding them it works as expected.
Will need to learn to do that, but can. |
|
Tests prepared here: coreobs#3 |
Fix lint and add tests to ozfortress#521
Legend, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.