Return generated matches on generate
#12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pieterjongsma
changed the title
generategenerate
…rate and TournamentSystem::DoubleElimination.generate
pieterjongsma
force-pushed
the
return-generated-matches
branch
from
81c61d5 to
f643d0e
Compare
pieterjongsma
commented
Oct 16, 2020
| expect(match1.home_team).to eq(2) | ||
| expect(match1.away_team).to eq(4) | ||
| expect(match2.home_team).to eq(1) | ||
| expect(match1.away_team).to eq(1) |
There was a problem hiding this comment.
It seemed to me that you would expect the same 'grand-final' as in the grand-final-only spec context.
pieterjongsma
changed the title
generategenerate
pieterjongsma
force-pushed
the
return-generated-matches
branch
6 times, most recently
from
df8cfa4 to
be3cc7d
Compare
pieterjongsma
force-pushed
the
return-generated-matches
branch
from
be3cc7d to
83252fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull makes
generatemethods return the generated matches. This is convenient when you want to use these matches later in an application, for example to assign them to playing fields.