Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OZ-715: Introducing test profiles + renamed "goTo" to "navigateTo" routines. #112

Merged
merged 3 commits into from
Oct 1, 2024

Conversation

kdaud
Copy link
Contributor

@kdaud kdaud commented Sep 30, 2024

Ticket: https://mekomsolutions.atlassian.net/browse/OZ-715

This PR adds ability to select preferred test profile (at runtime) that only runs a subset of the E2E test suite. Also renamed goToDrugOrderForm() → navigateToDrugOrderForm() and goToLabOrderForm() → navigateToLabOrderForm()

@kdaud kdaud force-pushed the OZ-715 branch 4 times, most recently from 77d52a5 to da580f7 Compare September 30, 2024 07:56
@kdaud kdaud requested a review from Ruhanga September 30, 2024 07:58
…gOrderForm() → navigateToDrugOrderForm() and goToLabOrderForm() → navigateToLabOrderForm().
@kdaud kdaud changed the title OZ-715: Adapted E2E test suite to run test profiles + renamed goToDrugOrderForm() → navigateToDrugOrderForm() and goToLabOrderForm() → navigateToLabOrderForm(). OZ-715: Added ability for E2E test suite to run test profiles + renamed goToDrugOrderForm() → navigateToDrugOrderForm() and goToLabOrderForm() → navigateToLabOrderForm(). Sep 30, 2024
@VaishSiddharth
Copy link
Contributor

VaishSiddharth commented Oct 1, 2024

I have left some comments apart from that the PR looks good!

Also I was looking into the e2e tests functions and I could see that there are a lot of delay statements present.
I think a better approach will be to use Playwright Auto-waiting functionality.
If we continue using delay statements I worry that the following will happen:

  • We will end up increasing the delay time with every PR to accommodate all scenarios where the UI load speeds are very slow.
  • These delays could reach to even minutes and hence our e2e tests eventually be slower on faster machines as well.

Having said that I suspect that we might not be able to remove all the delay statements but lets try to minimise them as much as we can.

This might require some refactoring so we might want to create a new ticket for this.

Please share your thoughts on this if any.
cc: @kdaud @mks-d @corneliouzbett @rbuisson

@kdaud
Copy link
Contributor Author

kdaud commented Oct 1, 2024

Also I was looking into the e2e tests functions and I could see that there are a lot of delay statements present.
I think a better approach will be to use Playwright Auto-waiting functionality.

We use Playwright's auto-waiting functionality in our tests, but there are cases where delays are added to ensure certain actions occur. For example, a 5-second delay is added after placing an order in O3 to allow synchronization with the lab and billing systems.

lets try to minimise them as much as we can.

I agree.

@kdaud kdaud requested a review from VaishSiddharth October 1, 2024 10:26
@mks-d mks-d changed the title OZ-715: Added ability for E2E test suite to run test profiles + renamed goToDrugOrderForm() → navigateToDrugOrderForm() and goToLabOrderForm() → navigateToLabOrderForm(). OZ-715: Introducing test profiles + renamed "goTo" to "navigateTo" routines. Oct 1, 2024
@kdaud kdaud merged commit 25be941 into main Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants